Repository navigation
Conversation
_expand_iterable concatenated the original sequence with a list of padding values. That works for lists but raises TypeError for tuples (`tuple + list`), even when no padding is needed. Coerce to a list first so rowalign, maxheadercolwidths, and the other sequence kwargs accept tuples like headers and colalign already do. Fixes astanin#434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434.
tabulate(..., rowalign=("top", "bottom"))raisedTypeError: can only concatenate tuple (not "list") to tuple. The same happened formaxheadercolwidthsand any other sequence passed through_expand_iterable.That helper padded with
original + [default] * n. Lists work; tuples do not, even when no padding is needed (tuple + []). Other sequence kwargs (headers,colalign, …) already accept tuples.Coerce
originalto a list before padding. Adds a unit test for_expand_iterableand a regression test thatrowalign=tuplematchesrowalign=list.