Repository navigation
Conversation
_wrap_text_to_colwidths passed the per-cell numparse flag to _type positionally, so it filled has_invisible and numparse stayed True. Values such as '80,443' were then cast with int() and raised ValueError even when disable_numparse=True. Pass numparse by keyword. Fixes astanin#428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428.
disable_numparse=Truewas ignored on themaxcolwidthswrap path, so values like'80,443'crashed withValueError: invalid literal for int()._wrap_text_to_colwidthspassed the per-cellnumparseflag to_typepositionally:_type's signature is_type(string, has_invisible=True, numparse=True), soFalsefilledhas_invisibleandnumparsestayedTrue. This is a regression of the #305 / #362 fix.Pass
numparseby keyword. Adds a regression test for the'80,443'repro from the issue.