Skip to content

feat(amgi-stomp): add STOMP support - #122

Open
TomKimber wants to merge 1 commit into
mainfrom
feat/add-stomp
Open

TomKimber wants to merge 1 commit into
mainfrom
feat/add-stomp

Conversation

@TomKimber

Copy link
Copy Markdown
Contributor

Add STOMP support: #51.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 22:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Python compatibility metadata and shutdown lifecycle handling currently permit installation and concurrency failures.

Review effort: Balanced
Findings: 1 High severity · 2 Medium severity

Open (3)
What changed in this PR

Adds a STOMP-backed AMGI server with sending, receiving, acknowledgements, documentation, examples, packaging, and CI coverage.

Changes:

  • Implements the amgi-stomp server and CLI entry point.
  • Adds unit and Artemis integration tests.
  • Integrates the package into the workspace, examples, tooling, and CI.
File Description
uv.lock Locks the new package and stompman.
tox.ini Adds STOMP test environments.
README.md Lists the STOMP server.
packages/​amgi-stomp/​tests_amgi_stomp/​test_stomp_message.py Tests core message behavior.
packages/​amgi-stomp/​tests_amgi_stomp/​test_stomp_message_integration.py Tests against Artemis.
packages/​amgi-stomp/​src/​amgi_stomp/​py.typed Marks the package as typed.
packages/​amgi-stomp/​src/​amgi_stomp/​__init__.py Implements the server and sender.
packages/​amgi-stomp/​README.md Documents installation and usage.
packages/​amgi-stomp/​pyproject.toml Defines package metadata and entry point.
packages/​amgi-stomp/​LICENSE Adds the package license.
example/​stomp/​docker-compose.yaml Provides an Artemis broker.
example/​README.md Documents the STOMP example.
example/​pyproject.toml Adds the example dependency.
.python-versions Makes Python 3.11 the primary version.
.pre-commit-config.yaml Adds stompman for type checking.
.github/​workflows/​tests.yml Adds STOMP to CI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/amgi-stomp/pyproject.toml
Comment thread packages/amgi-stomp/src/amgi_stomp/__init__.py Outdated
Comment thread packages/amgi-stomp/src/amgi_stomp/__init__.py Outdated
@read-the-docs-community

read-the-docs-community Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 AMGI | 🛠️ Build #35128136 | 📁 Comparing 02b6689 against latest (7f72e38)

  🔍 Preview build  

4 files changed
± specifications.html
± specifications/bindings.html
± specifications/lifespan.html
± specifications/message.html

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@TomKimber
TomKimber force-pushed the feat/add-stomp branch 2 times, most recently from d33e3b5 to 0b767b5 Compare October 1, 2026 23:14
@TomKimber
TomKimber requested a balanced review from Copilot October 10, 2026 19:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread packages/amgi-stomp/src/amgi_stomp/__init__.py Outdated
Comment thread packages/amgi-stomp/src/amgi_stomp/__init__.py Outdated
Comment thread packages/amgi-stomp/src/amgi_stomp/__init__.py
Comment thread packages/amgi-stomp/README.md Outdated
Comment thread packages/amgi-stomp/README.md Outdated
Comment thread packages/amgi-stomp/src/amgi_stomp/__init__.py Outdated
@TomKimber
TomKimber force-pushed the feat/add-stomp branch 2 times, most recently from 4749d79 to 895ca00 Compare October 10, 2026 19:29
Comment thread packages/amgi-stomp/tests_amgi_stomp/test_stomp_message_integration.py Outdated
Comment thread packages/amgi-stomp/tests_amgi_stomp/test_stomp_message_integration.py Outdated
Comment thread packages/amgi-stomp/tests_amgi_stomp/test_stomp_message_integration.py Outdated
@TomKimber
TomKimber force-pushed the feat/add-stomp branch 5 times, most recently from df37881 to c07b005 Compare October 13, 2026 20:27
@read-the-docs-community

read-the-docs-community Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 AsyncFast | 🛠️ Build #35128137 | 📁 Comparing 02b6689 against latest (7f72e38)

  🔍 Preview build  

1 file changed
± message_payload.html

@TomKimber
TomKimber force-pushed the feat/add-stomp branch 8 times, most recently from 7b0e915 to 2711fa7 Compare October 13, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants