Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Python compatibility metadata and shutdown lifecycle handling currently permit installation and concurrency failures.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds a STOMP-backed AMGI server with sending, receiving, acknowledgements, documentation, examples, packaging, and CI coverage.
Changes:
- Implements the
amgi-stompserver and CLI entry point. - Adds unit and Artemis integration tests.
- Integrates the package into the workspace, examples, tooling, and CI.
| File | Description |
|---|---|
uv.lock |
Locks the new package and stompman. |
tox.ini |
Adds STOMP test environments. |
README.md |
Lists the STOMP server. |
packages/amgi-stomp/tests_amgi_stomp/test_stomp_message.py |
Tests core message behavior. |
packages/amgi-stomp/tests_amgi_stomp/test_stomp_message_integration.py |
Tests against Artemis. |
packages/amgi-stomp/src/amgi_stomp/py.typed |
Marks the package as typed. |
packages/amgi-stomp/src/amgi_stomp/__init__.py |
Implements the server and sender. |
packages/amgi-stomp/README.md |
Documents installation and usage. |
packages/amgi-stomp/pyproject.toml |
Defines package metadata and entry point. |
packages/amgi-stomp/LICENSE |
Adds the package license. |
example/stomp/docker-compose.yaml |
Provides an Artemis broker. |
example/README.md |
Documents the STOMP example. |
example/pyproject.toml |
Adds the example dependency. |
.python-versions |
Makes Python 3.11 the primary version. |
.pre-commit-config.yaml |
Adds stompman for type checking. |
.github/workflows/tests.yml |
Adds STOMP to CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Documentation build overview
4 files changed± specifications.html± specifications/bindings.html± specifications/lifespan.html± specifications/message.html |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d33e3b5 to
0b767b5
Compare
0b767b5 to
ddfc54b
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Shutdown races, an ineffective handler timeout, and the Python 3.10 import path must be corrected.
6 open findings
Guard typing.Self import for Python 3.10 · New Enforce shutdown deadline while waiting for handlers · New Disable callbacks before draining shutdown tasks · New Document broker-dependent NACK redelivery behavior · New Clarify STOMP receipts do not guarantee message durability · New Avoid promising redelivery after STOMP NACK · New
3 resolved since last review
🧠 Review effort: Balanced
4749d79 to
895ca00
Compare
df37881 to
c07b005
Compare
7b0e915 to
2711fa7
Compare
2711fa7 to
02b6689
Compare



Add STOMP support: #51.