Repository navigation
Conversation
Documentation build overview
3 files changed± specifications/bindings.html± specifications/lifespan.html± specifications/message.html |
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the requested AsyncAPI behavior and includes focused validation, tests, and documentation.
0 open findings
What changed in this PR
Adds AsyncAPI request/reply schema support, including dynamic reply addresses, public APIs, documentation, and tests.
Changes:
- Adds
ReplyandReplyAddresschannel configuration. - Generates AsyncAPI operation reply definitions with validation.
- Documents and tests basic, dynamic-address, and same-channel replies.
| File | Description |
|---|---|
packages/asyncfast/src/asyncfast/_channel.py |
Defines reply models and stores reply configuration. |
packages/asyncfast/src/asyncfast/_asyncfast.py |
Adds reply configuration to the channel decorator. |
packages/asyncfast/src/asyncfast/_asyncapi.py |
Generates and validates reply schema definitions. |
packages/asyncfast/src/asyncfast/__init__.py |
Exports the new public APIs. |
packages/asyncfast/tests_asyncfast/test_errors.py |
Tests invalid reply configurations. |
packages/asyncfast/tests_asyncfast/test_asyncapi.py |
Tests generated request/reply schemas. |
packages/asyncfast/docs/request_reply.rst |
Documents request/reply usage. |
packages/asyncfast/docs/index.rst |
Adds the guide to the documentation index. |
packages/asyncfast/docs/examples/request_reply.py |
Provides a basic example. |
packages/asyncfast/docs/examples/request_reply_dynamic_address.py |
Demonstrates dynamic reply addresses. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TomKimber
force-pushed
the
feat/add-request-reply-support
branch
from
October 10, 2026 19:08
e3aa5f8 to
02a63f0
Compare
TomKimber
force-pushed
the
feat/add-request-reply-support
branch
from
October 10, 2026 19:20
02a63f0 to
9cd436c
Compare
TomKimber
force-pushed
the
feat/add-request-reply-support
branch
from
October 12, 2026 19:12
9cd436c to
1d7fa14
Compare
TomKimber
force-pushed
the
feat/add-request-reply-support
branch
from
October 13, 2026 20:54
1d7fa14 to
3633f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Request/Reply support: #43.