Skip to content

fix(deps): resolve npm audit failures (DD-4224) - #40

Merged
contrem merged 1 commit into
masterfrom
DD-4224/fix/npm-audit
Oct 28, 2026
Merged

contrem merged 1 commit into
masterfrom
DD-4224/fix/npm-audit

Conversation

@contrem

@contrem contrem commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Linear Link

https://linear.app/atomicbuilt/issue/DD-4224

Fixes the failing vuln-dep-check job, which currently fails on master because of high-severity advisories for transitive dependencies (through vitest).

npm run audit:fix (lockfile only, no breaking changes) resolves:

npm audit now reports 0 vulnerabilities at any severity.

Verified locally on Node 24.19.0 (matching master's .nvmrc), running every step of test.yml: npm ci, "Validate lockfile", format:ci, 4/4 tests and typecheck:ci all pass, and audit-ci passes. Because .npmrc sets min-release-age=2 and audit:fix bypasses it, I also confirmed that npm install --package-lock-only with the default settings produces no lockfile drift, on both Node 24.19.0 and 24.22.1.

Unblocks vuln-dep-check on #39 (DD-4223).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which cleans up code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change impacts security

Checklist:

  • New and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have followed the Code Review and Code Review Security guidelines
  • I have checked my code against flaws from the OWASP Top 10
    • A01:2021-Broken Access Control
    • A02:2021-Cryptographic Failures
    • A03:2021-Injection
    • A04:2021-Insecure Design
    • A05:2021-Security Misconfiguration
    • A06:2021-Vulnerable and Outdated Components
    • A07:2021-Identification and Authentication Failures
    • A08:2021-Software and Data Integrity Failures
    • A09:2021-Security Logging and Monitoring Failures
    • A10:2021-Server-Side Request Forgery

🤖 Generated with Claude Code

Run npm run audit:fix to pick up patched transitive versions.

Refs DD-4224

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@contrem
contrem requested a review from sean-hill October 28, 2026 19:08
@contrem
contrem merged commit 50c6e35 into master Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants