Skip to content

fix(linux): include Git LFS and validate linked-worktree payloads - #44

Merged
zoeyrose merged 1 commit into
mainfrom
fix/issue-43-linux-git-lfs
Sep 7, 2026
Merged

fix(linux): include Git LFS and validate linked-worktree payloads#44
zoeyrose merged 1 commit into
mainfrom
fix/issue-43-linux-git-lfs

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Sep 7, 2026

Copy link
Copy Markdown
Member

Summary

Provide Git LFS in the reusable Linux images so terminal workspace checkout and linked-worktree operations have their required tooling.

Implementation / behavior

Pin the package/tool versions and validate actual LFS payload materialization as a non-root user in broad and Classic Linux images. Preserve separate release and consumer adoption gates in atrinik/atrinik#567.

Validation

Delivery validation and review are in progress. Final evidence will be recorded before readiness.

Limitations / follow-up

Image publication follows maintainer merge and semantic-release. Consumer pin adoption is owned by atrinik/atrinik#567; runtime source-generation hydration by atrinik/atrinik#566.

Closes #43

Final delivery validation

Current revision: f4e1b2a53197c22ee88d8c9f108a99f7623328c4, based on 96def79230e438980bbad04ed9da6286b91fc358 (main).

This is the final validation record and supersedes the initial in-progress note above.

  • Independent full-diff review found no actionable defects. The committed tracked patch and smoke script match the reviewed candidate bytes.
  • Passed on the committed revision: ShellCheck, actionlint, toolchain manifest validation, required-check aggregation tests, 21 dependency/shader/Vulkan Python tests, and git diff --check.
  • Image validation passed: broad Linux image, Classic validation/final images, Windows cross-build images, native Windows tests, and the aggregate Required checks. The Linux and Classic logs each contain two successful LFS smokes and confirm package 3.7.1-1; Classic's two test suites passed all 53 and 91 tests.
  • Candidate measurement and its native Windows check, CodeQL, and Conventional PR title passed. No applicable checks were skipped or waived.
  • Final recheck: unchanged base/head and merge base, clean worktree, zero actionable review findings, no unresolved review threads, and conflict-free mergeability. The original implementation candidate was preserved rather than recreated.
  • Local coordinator image builds were not run: the pinned terminal coordinator has no Docker client/daemon. Historical local image results are not counted as final-head evidence.

Verification and release boundary

For a repeat from this revision's worktree in a Docker-enabled build environment:

docker build --file linux/Dockerfile --target validation --tag atrinik-issue-43-linux-validation:review .
docker build --file linux/Dockerfile --target final --tag atrinik-issue-43-linux:review .
docker build --file linux/Dockerfile --target classic-validation --tag atrinik-issue-43-classic-validation:review .
docker build --file linux/Dockerfile --target classic-final --tag atrinik-issue-43-classic:review .
for image in atrinik-issue-43-linux:review atrinik-issue-43-classic:review; do
  docker run --rm --user ubuntu --env HOME=/home/ubuntu "$image" git lfs version
  docker run --rm --user ubuntu --env HOME=/home/ubuntu "$image" atrinik-git-lfs-smoke
done

Expected: Git LFS 3.7.1 and git-lfs smoke: passed, proving the committed pointer and materialized linked-worktree payload separately. These tests use disposable local repositories, require no LFS server credentials, and can be repeated without game runtime state.

Other-image audit: the unchanged Windows/MXE images are cross-build workers, not supported terminal delivery coordinators. Their pinned base package database contains no git-lfs; this PR does not add it there. If LFS checkout inside those workers is required, that needs a separately scoped prerequisite change. This Linux fix does not claim Windows LFS support.

No release version, registry digest or consumer pin is fabricated here. Maintainer merge and semantic-release precede consumer adoption in atrinik/atrinik#567. Tool availability does not resolve runtime source-generation hydration (atrinik/atrinik#566) or the separate aggregate inventory audit (atrinik/atrinik#568).

@zoeyrose zoeyrose moved this to Review in Atrinik work Sep 7, 2026
@zoeyrose
zoeyrose marked this pull request as ready for review September 7, 2026 21:56
@zoeyrose
zoeyrose merged commit f51d809 into main Sep 7, 2026
16 checks passed
@zoeyrose
zoeyrose deleted the fix/issue-43-linux-git-lfs branch September 7, 2026 23:03
@github-project-automation github-project-automation Bot moved this from Review to Done in Atrinik work Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix(linux): include Git LFS for terminal workspace bootstrap

1 participant