fix(linux): include Git LFS and validate linked-worktree payloads - #44
Merged
Conversation
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide Git LFS in the reusable Linux images so terminal workspace checkout and linked-worktree operations have their required tooling.
Implementation / behavior
Pin the package/tool versions and validate actual LFS payload materialization as a non-root user in broad and Classic Linux images. Preserve separate release and consumer adoption gates in atrinik/atrinik#567.
Validation
Delivery validation and review are in progress. Final evidence will be recorded before readiness.
Limitations / follow-up
Image publication follows maintainer merge and semantic-release. Consumer pin adoption is owned by atrinik/atrinik#567; runtime source-generation hydration by atrinik/atrinik#566.
Closes #43
Final delivery validation
Current revision:
f4e1b2a53197c22ee88d8c9f108a99f7623328c4, based on96def79230e438980bbad04ed9da6286b91fc358(main).This is the final validation record and supersedes the initial in-progress note above.
git diff --check.3.7.1-1; Classic's two test suites passed all 53 and 91 tests.Verification and release boundary
For a repeat from this revision's worktree in a Docker-enabled build environment:
Expected: Git LFS
3.7.1andgit-lfs smoke: passed, proving the committed pointer and materialized linked-worktree payload separately. These tests use disposable local repositories, require no LFS server credentials, and can be repeated without game runtime state.Other-image audit: the unchanged Windows/MXE images are cross-build workers, not supported terminal delivery coordinators. Their pinned base package database contains no
git-lfs; this PR does not add it there. If LFS checkout inside those workers is required, that needs a separately scoped prerequisite change. This Linux fix does not claim Windows LFS support.No release version, registry digest or consumer pin is fabricated here. Maintainer merge and semantic-release precede consumer adoption in atrinik/atrinik#567. Tool availability does not resolve runtime source-generation hydration (atrinik/atrinik#566) or the separate aggregate inventory audit (atrinik/atrinik#568).