fix: preserve semantic version in node metric - #403
Open
Cryptoloveer wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for the PR! Atto node releases use a two-component version format (e.g. This change would also make the There is, however, a known issue when the node version ends in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NodeMetricProviderconverts the application version to aDoublebefore registering the metric. That works for two-part values such as2.1, but semantic versions such as7.0.2cannot be represented as aDouble;toDoubleOrNull()therefore falls back to0.0. The exportedversiontag consequently loses the actual release version.Fix
Treat
node.versionas an information-style gauge:1;versiontag;-SNAPSHOT, matching the existing behavior.Validation
Added focused tests covering:
-SNAPSHOTsuffix;The change is limited to node-version metric registration and its tests.