Skip to content

Excluded rating type from stops counter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hazzy159 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Excluded rating type from stops counter #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/StartCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export const StartCard = React.memo<StartCardProps>(({

// Get offline mode for the tour (defaults to 'optional')
const offlineMode = getOfflineMode(tour);
const stopsCount = tour.stops.filter(item => item.type !== 'rating').length;

return (
// No fixed height. We let the content define the height, and the parent measures it.
Expand All @@ -270,7 +271,7 @@ export const StartCard = React.memo<StartCardProps>(({
</MetaItem>
<MetaItem>
<PathIcon size={18} />
<span>{tour.stops.length} {t.startCard.stops}</span>
<span>{stopsCount} {t.startCard.stops}</span>
</MetaItem>
</MetaContainer>
<Description>
Expand Down
3 changes: 2 additions & 1 deletion components/TourSelectionCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export const TourSelectionCard = React.memo<TourSelectionCardProps>(({ tour, onC
const showImage = tourCard?.showImage !== false;
const showDescription = tourCard?.showDescription !== false;
const showMeta = tourCard?.showMeta !== false;
const stopsCount = tour.stops.filter(item => item.type !== 'rating').length;

return (
<Card
Expand All @@ -118,7 +119,7 @@ export const TourSelectionCard = React.memo<TourSelectionCardProps>(({ tour, onC
</MetaItem>
<MetaItem>
<PathIcon size={16} />
<span>{tour.stops.length} {t.startCard.stops}</span>
<span>{stopsCount} {t.startCard.stops}</span>
</MetaItem>
</MetaContainer>
)}
Expand Down