Conversation
In useMediaSessionIntegration.ts on every state update, a new artwork array was being created. The library's useMediaMeta treated this as a metadata change and re-published MediaMetadata, which caused the browser to request the image again. In Network the initiator was use-media-session.js. I memoized the array by the stop's image URL. I checked in the browser: after Play/Pause toggles, the metadata with the cover was not reassigned again, and the number of requests to the stop's image did not increase. When the stop changes, the URL changes, so its cover updates as expected.
|
@hazzy159 is attempting to deploy a commit to the michalacler-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In useMediaSessionIntegration.ts on every state update, a new artwork array was being created. The library's useMediaMeta treated this as a metadata change and re-published MediaMetadata, which caused the browser to request the image again. In Network the initiator was use-media-session.js.
I memoized the array by the stop's image URL. I checked in the browser: after Play/Pause toggles, the metadata with the cover was not reassigned again, and the number of requests to the stop's image did not increase. When the stop changes, the URL changes, so its cover updates as expected.