Skip to content

security(e2e): warn at startup when --env=e2e is set #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lakhansamani wants to merge 1 commit into
base: worktree-playground-e2e
Choose a base branch
from
+10 −0
Open

security(e2e): warn at startup when --env=e2e is set #732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,16 @@ func runRoot(c *cobra.Command, args []string) {
}
}

// Warn if --env=e2e is set — this relaxes SSRF protection (private/loopback-IP
// rejection) for the per-org SSO broker and webhook registration/delivery, and
// routes social-login OAuth and SMS sending to fixed e2e-playground mock
// addresses. It exists solely for e2e-playground/docker-compose.yml and must
// never be set on a real deployment; unlike production/staging, there is no
// other visible symptom if it is (see internal/constants/env.go's E2EEnv doc).
if rootArgs.config.Env == constants.E2EEnv {
log.Warn().Msg("running with --env=e2e: SSRF protection is relaxed for the SSO broker and webhooks, and OAuth/SMS are routed to e2e-playground mock addresses. This must never be set in a real deployment.")
}

// Initialize prometheus metrics
metrics.Init()

Expand Down
Loading