Skip to content

feat(llm): default Todo2code to SubLLM Z.AI GLM 5.3 - #108

Merged
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
ticket/089-subllm-zai-glm53-v2
Aug 26, 2026
Merged

feat(llm): default Todo2code to SubLLM Z.AI GLM 5.3#108
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
ticket/089-subllm-zai-glm53-v2

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Replaces #104 after splitting its integration and LLM workstreams. Ticket-090 is already merged in #107.

Summary

  • enable public SubLLM by default for semantic requests
  • resolve direct Z.AI glm-5.3 with canonical autogrammar/todo2code provenance
  • preserve OpenRouter only behind explicit T2C_USE_SUBLLM=false
  • fail closed when the selected SubLLM route is unavailable

Validation

  • make verify
  • ./project/governance-check.sh
  • git diff --check

Ticket: ticket-089

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head b06ea800b98724466f74bd2ab1044bb3d0b96a0f.

Ticket: ticket-089
Correlation ID: todo2code-pr-108-ticket-089
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Ticket-089 makes SubLLM the default routing policy for semantic LLM requests, with an explicit T2C_USE_SUBLLM=false legacy opt-out. Changes match the stated goal: default routing flips to SubLLM, direct Z.AI fixture updates to glm-5.3 with the canonical autogrammar/todo2code URL, unit test helpers opt into the legacy transport so tests remain hermetic, and governance scaffolding is complete and consistent with the ticket index and TODO entries. | Chunk 2 of 2 updates tests for the new default Z.AI route: wire model bumped from glm-5.2 to glm-5.3, route priority 10 -> 0, and a new test asserts SubLLM is the default semantic route with OpenRouter only available behind explicit T2C_USE_SUBLLM=false. Changes are test-only and consistent with the PR description.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-089-9175
TICKET ticket-089
HEAD_SHA b06ea800b98724466f74bd2ab1044bb3d0b96a0f
CORRELATION_ID todo2code-pr-108-ticket-089
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head ec7258fcfdd5b13bf9e9fe98bb782dbccacc97ba.

Ticket: ticket-089
Correlation ID: todo2code-pr-108-ticket-089
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Chunk 1 of ticket-089: switches semantic LLM routing to SubLLM-by-default (always true unless T2C_USE_SUBLLM explicitly disables), updates Z.AI fixture/model from glm-5.2 to glm-5.3 and canonical repo URL, adds governance artifacts. Tests pass. | Test updates align with the PR's model bump from glm-5.2 to glm-5.3, priority change to 0, and the new default SubLLM routing with legacy OpenRouter opt-out. New test verifies default routing and explicit opt-out behavior. All provided test results pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-089-1461
TICKET ticket-089
HEAD_SHA ec7258fcfdd5b13bf9e9fe98bb782dbccacc97ba
CORRELATION_ID todo2code-pr-108-ticket-089
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","Java adapter (JDK 17 required)=PASS","verify=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head ec7258fcfdd5b13bf9e9fe98bb782dbccacc97ba.

Ticket: ticket-089
Correlation ID: todo2code-pr-108-ticket-089-ec7258fcfd
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Ticket-089 makes SubLLM the default semantic routing policy with direct Z.AI GLM 5.3, retaining the legacy OpenRouter path only behind T2C_USE_SUBLLM=false. Governance scaffolding (README, intent., changelog, preprompt) is consistent with the code changes, and the test fixtures/expectations are updated to glm-5.3 and the canonical autogrammar/todo2code URL. | Test chunk updates model identifier to glm-5.3, lowers priority to 0, and adds coverage for SubLLM-default routing behavior with explicit opt-out. All visible checks pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-089-1933
TICKET ticket-089
HEAD_SHA ec7258fcfdd5b13bf9e9fe98bb782dbccacc97ba
CORRELATION_ID todo2code-pr-108-ticket-089-ec7258fcfd
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","Java adapter (JDK 17 required)=PASS","verify=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 16be387 into main Aug 26, 2026
21 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/089-subllm-zai-glm53-v2 branch August 26, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant