Support separate SAP logins per surface - #640
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-surface SAP flows previously parsed
login:but refused to record. Stage each surface’s credentials before its first activation, retain its identity when returning to it, and resolve credentials again for replay. Traces contain the user reference, never the password. Replay rejects removed or changed login references instead of silently using a different identity.Validation: full agent, CLI, and driver unit suites; a simulated two-identity SAP record/replay including a return to the first surface; credential leakage and changed-identity regressions; clippy. Real Windows SAP verification remains outstanding.
This is the engine dependency for the desktop environment-scoped surface authoring changes. Both must be released together; merging alone does not update the desktop’s bundled engine.