Skip to content

chore: release v11.0.18#295

Merged
avoidwork merged 2 commits into
masterfrom
chore/release-11.0.18
Jun 26, 2026
Merged

chore: release v11.0.18#295
avoidwork merged 2 commits into
masterfrom
chore/release-11.0.18

Conversation

@avoidwork

Copy link
Copy Markdown
Owner

Release v11.0.18

@avoidwork avoidwork merged commit e5a5be6 into master Jun 26, 2026
2 checks passed
@avoidwork avoidwork deleted the chore/release-11.0.18 branch June 26, 2026 00:36
@augmentcode

augmentcode Bot commented Jun 26, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Prepares the v11.0.18 release of filesize.js.

Changes:

  • Bumps the package version to 11.0.18 and updates version headers in generated dist artifacts
  • Updates CHANGELOG.md with the entries included in the release
  • Regenerates dist bundles with improved handling of pad + locale formatting

Technical Notes: Locale padding is now delegated to toLocaleString() via fixed fraction-digit options to avoid mis-parsing grouping vs decimal separators.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread dist/filesize.js
// number of fraction digits. The manual string padding below cannot tell a
// locale-inserted grouping separator from the decimal separator, so it
// dropped digits (e.g. "1,234,500" became "1,234").
const localePad =

@augmentcode augmentcode Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist/filesize.js:293 — localePad sets minimumFractionDigits/maximumFractionDigits directly from round; Intl.NumberFormat typically enforces an upper bound (commonly 20), so pad: true + locale with a large round may throw a RangeError at runtime rather than formatting/padding.

Severity: medium

Other Locations
  • dist/filesize.cjs:297
  • dist/filesize.umd.js:293

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Comment thread CHANGELOG.md

#### [11.0.17](https://github.com/avoidwork/filesize.js/compare/11.0.16...11.0.17)

#### [11.0.18](https://github.com/avoidwork/filesize.js/compare/11.0.16...11.0.18)

@augmentcode augmentcode Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md:7 — The compare link for 11.0.18 points to 11.0.16...11.0.18; is it intentional to skip 11.0.17 here? If 11.0.17 was released/tagged, this link may be misleading for readers.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant