Repository navigation
fix: preserve cleanup list links across TTL expiry - #510
Merged
avoidwork merged 1 commit intoOct 21, 2026
Merged
Conversation
Owner
|
This is 13.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an item reaches its TTL between cleanup's removal pass and its list rebuild, the rebuild drops it from the list but leaves it in
itemsandsize. A subsequentevict()then throws. Remove the redundant rebuild: cleanup already maintains the list through#unlink().Type of Change
Testing
Added a deterministic clock regression that fails before the fix and checks retained list pointers and subsequent eviction. All 173 unit tests pass; Oxlint, formatting of the changed files, and Rollup's CJS/ESM/minified builds pass.
npm run lintstill reports formatting in six unchanged files (three benchmarks, two distribution files, and rollup.config.js). Built files were not committed. The multi-Node/browser matrix was not run locally.Coverage
Checklist
npm run lintpasses