Skip to content

ci: call OpenTelemetry orchestrator workflow - #653

Merged
zhongkechen merged 2 commits into
mainfrom
codex/use-opentelemetry-orchestrator
Aug 18, 2026
Merged

ci: call OpenTelemetry orchestrator workflow#653
zhongkechen merged 2 commits into
mainfrom
codex/use-opentelemetry-orchestrator

Conversation

@zhongkechen

Copy link
Copy Markdown
Contributor

Summary

  • call the reusable OpenTelemetry orchestrator workflow directly
  • configure the orchestrator with the Python SDK settings previously supplied by the language wrapper
  • add a workflow contract test and run it in the GitHub script test job

Testing

  • pytest .github/scripts/tests/test_build_lambda_layer.py .github/scripts/tests/test_opentelemetry_conformance_workflow.py .github/scripts/tests/test_parse_sdk_branch.py -q
  • Ruff check and format validation for the new test
  • YAML parsing and git diff --check

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 18, 2026 18:17 — with GitHub Actions Inactive
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 18, 2026 18:17 — with GitHub Actions Inactive
@zhongkechen
zhongkechen merged commit 9d943a7 into main Aug 18, 2026
29 checks passed
@zhongkechen
zhongkechen deleted the codex/use-opentelemetry-orchestrator branch August 18, 2026 18:39
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual risk is limited to runtime behavior of the pinned external reusable workflow, which is outside this diff.

Reviewed commit 564b480ced50db37f543c313c63b798a8732e21e. Workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Claude AI review

No actionable findings.

This is a well-scoped CI-only change. The workflow now calls the generic opentelemetry-orchestrator.yml (same pinned SHA 397d523d…) with the Python settings passed explicitly, and the python_sdk_refsdk_ref rename preserves the identical ${{ github.event.pull_request.head.sha || github.sha }} resolution for pull_request/push/workflow_dispatch. The updated contract test in .github/scripts/tests/test_opentelemetry_conformance_workflow.py is internally consistent with the proposed workflow: every asserted string is present, and the relaxation from "otlp_endpoint:" to "\n otlp_endpoint:" is required (the new collector_otlp_endpoint: input contains the old substring) while still guarding the deprecated bare input without false-positiving on collector_otlp_endpoint:. The test is wired into test-parser.yml, satisfying the repo's test requirement for a CI-config change.

Residual test risk: The contract test is purely a text-substring check — it does not validate that the external opentelemetry-orchestrator.yml at the pinned SHA actually declares the inputs now being passed (language, resource_prefix, sdk_repository, checkout_sdk, contract_test_command, adot_release_repository, collector_compatible_runtime, collector_otlp_endpoint, suite_timeout_minutes, and the retained phase/delay_seconds/aws_region). If the orchestrator's input contract differs, the caller would fail at dispatch time, and this in-repo test would not catch it. This is unverifiable from within this repository; confirming it requires checking the orchestrator definition in aws/aws-durable-execution-conformance-tests at that revision.

Reviewed commit 564b480ced50db37f543c313c63b798a8732e21e. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants