Skip to content

ci: run conformance tests on pushes to main - #667

Merged
wangyb-A merged 1 commit into
mainfrom
ci-conformance-run-on-main-push
Aug 21, 2026
Merged

ci: run conformance tests on pushes to main#667
wangyb-A merged 1 commit into
mainfrom
ci-conformance-run-on-main-push

Conversation

@wangyb-A

Copy link
Copy Markdown
Contributor

Summary

Adds a push trigger for the main branch to the Conformance Tests workflow so the suite also runs after commits land on main, not only on pull requests.

Change

Under on:, a push: { branches: ["main"] } trigger is added immediately before the existing pull_request trigger.

Behavior

  • Conformance now runs on every push to main (e.g. after a PR merges), providing post-merge validation of the integrated state.
  • The existing pull_request trigger and its paths filters are unchanged, so PR-time path filtering behaves exactly as before.
  • workflow_dispatch, concurrency, and all jobs are untouched.

Note: the push trigger intentionally has no paths filter, so any push to main runs the suite.

@wangyb-A
wangyb-A marked this pull request as ready for review August 21, 2026 18:30
@wangyb-A
wangyb-A temporarily deployed to ai-pr-review-runtime August 21, 2026 18:30 — with GitHub Actions Inactive
@wangyb-A
wangyb-A temporarily deployed to ai-pr-review-runtime August 21, 2026 18:30 — with GitHub Actions Inactive
@wangyb-A
wangyb-A merged commit 7f532f8 into main Aug 21, 2026
28 of 29 checks passed
@wangyb-A
wangyb-A deleted the ci-conformance-run-on-main-push branch August 21, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual risk is limited to GitHub Actions runtime behavior; repository code was not executed as required.

Reviewed commit b75570d92b4301978a979722fd15085caca9fdf2. Workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Claude AI review

No actionable findings. This PR adds a push: { branches: ["main"] } trigger to .github/workflows/conformance-tests.yml so the conformance suite also runs after commits land on main.

The change is correct: the YAML is valid, same-repo push events have access to the required secrets and id-token: write for AWS OIDC, and AWS_REGION falls back to us-west-2 since github.event.inputs is undefined outside workflow_dispatch. The existing global concurrency lock (conformance-tests-global, cancel-in-progress: false) already serializes runs against the shared per-suite CloudFormation stacks, so a post-merge push run safely queues behind any in-flight PR run rather than colliding on the shared --no-cleanup stacks. The pull_request trigger and its paths filter are unchanged.

Residual (non-blocking) risk, not a defect:

  • The push trigger deliberately has no paths filter (called out in the PR description), so the full conformance suite — which deploys real AWS infrastructure and holds the repo-wide serialized lock — now runs on every push to main, including doc-only or unrelated-package changes. This increases cost and queue contention on the global lock.
  • With cancel-in-progress: false and a static concurrency group, only one run can be pending at a time; rapid successive pushes to main can cause an earlier queued run to be superseded by a newer one, so not literally every push completes a conformance run. If per-push post-merge validation matters, consider mirroring the pull_request paths filter on the push trigger.

Reviewed commit b75570d92b4301978a979722fd15085caca9fdf2. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants