Repository navigation
docs: define supported OTel sampling modes - #885
Open
zhongkechen wants to merge 1 commit into
Open
zhongkechen wants to merge 1 commit into
zhongkechen wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Related to aws/aws-durable-execution-docs#295.
Merge order: Merge the shared guide aws/aws-durable-execution-docs#304 first so the new canonical sampling link resolves.
Description of changes
Define the supported sampling modes for durable spans: preserve an explicit upstream
Sampleddecision, or use a deterministic decision from the canonical trace ID with configuration unchanged across retries and reinvocations. Clarify that non-deterministic local policies are unsupported when no upstream decision exists, and in-memory reuse does not extend that support boundary.Preserve Python's header → same-trace ambient span → configured sampler precedence. Correct ratio verification and troubleshooting guidance so readers check upstream decisions and whole executions instead of expecting sampled operations to disappear independently.
Design
Documentation only; no design note or simpler code alternative is needed. No runtime source, public API, or test expectations change. The README previously left the support boundary implicit and described ratio verification without its upstream-decision precondition.
Assumptions
Header and ambient precedence, per-invocation resolution, and durable-span decision reuse match
durable_sampling.pyand the existing sampler tests. The shared guide anchor is introduced by the prerequisite PR above.Decisions not covered by the issue or the design note
Validation
git diff --check origin/main..HEADChecklist
Runtime branch coverage, regression-first tests, and edited test expectations are not applicable to this README-only change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.