Skip to content

Stop removing nodes in maintenance from in replacement set - #728

Merged
hgreebe merged 2 commits into
aws:developfrom
hgreebe:develop
Jul 28, 2026
Merged

Stop removing nodes in maintenance from in replacement set#728
hgreebe merged 2 commits into
aws:developfrom
hgreebe:develop

Conversation

@hgreebe

@hgreebe hgreebe commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description of changes

  • Stop removing nodes in maintenance from in replacement set
  • Resolve bug where static nodes instance replacement fails when node is in a user created maintenance reservation
  • Does not remove nodes in maintenance from nodes_still_in_replacement
  • Nodes in maintenance will still wait the replacement timeout window before they are deemed unhealthy

Tests

  • Ran:
test-suites:
  schedulers:
    test_slurm.py::test_slurm_maintenance_reservation:
      dimensions:
        - regions: ["us-east-1"]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["alinux2023"]
          schedulers: ["slurm"]

References

*Bug originally introduced in this PR: #591

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hgreebe
hgreebe marked this pull request as ready for review July 27, 2026 13:08
@hgreebe
hgreebe requested review from a team as code owners July 27, 2026 13:08
Comment thread src/slurm_plugin/clustermgtd.py
@hgreebe
hgreebe merged commit f0b55b9 into aws:develop Jul 28, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants