[clustermgtd] Fix spurious errors logged on transient IMDS unavailability - #731
Merged
Merged
Conversation
…lity. The retry introduced to mitigate the impact of transient IMDS unavailability during the compute fleet status retrieval was not effective, for two reasons: * its window (3 attempts, 1s apart) was shorter than the IMDS outages observed in the fleet, which are in the order of a few seconds, so the retries were exhausted before IMDS became available again; * every failed attempt was logged as an error by _run_command, so even the attempts recovered by a successful retry left errors in the log, describing failures that no longer had any impact on the cluster. Waits are now 1s, 2s and 4s, plus a jitter of up to 1s each to avoid retrying in lockstep with the other daemons polling IMDS, and errors on the single attempts are no longer logged: the failure is reported once by get_status, only after the retries are exhausted, so that genuinely prolonged IMDS outages are still visible.
gmarciani
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a follow-up to #704 (commit 1c00989), which added a retry to the compute fleet status retrieval in clustermgtd to "mitigate the impact of networking glitches, such as transient unavailability of IMDS". That retry did not achieve the intended effect, for two reasons:
_run_command, so even the attempts recovered by a successful retry left errors in the log, describing failures that no longer had any impact on the cluster.Either one alone is enough to fail the log assertion, so both are addressed:
log_error=False. The failure is reported once byget_status, only after the retries are exhausted, so that genuinely prolonged IMDS outages remain visible.This follows the same principle already established in d8e8b25, where a failure covered by an outer retry was downgraded and the error left to the caller that observes the exhausted retries.
Tests
test_slurm_scalingwhich this issue was initially detected is ongoingChecklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.