Skip to content

test: assert CDK warning on stderr in package/deploy/validate integ test - #9177

Merged
reedham-aws merged 1 commit into
aws:developfrom
madhavdonthula1:fix/cdk-warning-stderr-tests
Aug 13, 2026
Merged

test: assert CDK warning on stderr in package/deploy/validate integ test#9177
reedham-aws merged 1 commit into
aws:developfrom
madhavdonthula1:fix/cdk-warning-stderr-tests

Conversation

@madhavdonthula1

Copy link
Copy Markdown
Contributor

The output json integration (#9172) moved the CDK not-supported warning from stdout to stderr so it does not pollute the machine-readable --output json stdout stream. Three integration tests still asserted the warning on stdout and now fail on develop:

  • package/test_package_command_zip.py::test_package_logs_warning_for_cdk_project
  • deploy/test_deploy_command.py::test_deploy_logs_warning_with_cdk_project
  • validate/test_validate_command.py::test_validate_logs_warning_for_cdk_project

Update each to assert the warning on stderr (capturing stderr in the package test's Popen). Test-only change; product behavior is unchanged.

…ests

The output json integration (aws#9172) moved the CDK not-supported warning from
stdout to stderr so it does not pollute the machine-readable --output json
stdout stream. Three integration tests still asserted the warning on stdout and
now fail on develop:
 - package/test_package_command_zip.py::test_package_logs_warning_for_cdk_project
 - deploy/test_deploy_command.py::test_deploy_logs_warning_with_cdk_project
 - validate/test_validate_command.py::test_validate_logs_warning_for_cdk_project

Update each to assert the warning on stderr (capturing stderr in the package
test's Popen). Test-only change; product behavior is unchanged.
@madhavdonthula1
madhavdonthula1 requested a review from a team as a code owner August 13, 2026 20:40
@github-actions github-actions Bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 13, 2026
@reedham-aws
reedham-aws enabled auto-merge August 13, 2026 20:43
@reedham-aws
reedham-aws added this pull request to the merge queue Aug 13, 2026
Merged via the queue into aws:develop with commit d8dc699 Aug 13, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants