Repository navigation
Conversation
kuhe
force-pushed
the
kuhe/feat/sync-api
branch
from
October 28, 2026 18:08
0f5a3cd to
d8c8ffd
Compare
kuhe
marked this pull request as ready for review
October 28, 2026 19:57
stobrien89
requested changes
Oct 29, 2026
| from copy import deepcopy | ||
| import logging | ||
| from typing import Any, cast | ||
|
|
||
| from smithy_aws_core.aio.identity.chain import AsyncIdentityChain |
Member
There was a problem hiding this comment.
we should bump the runtime dependency floors- installing the client with its declared dependencies currently fails on this import
|
|
||
| deserializer.read_struct(_SCHEMA_SERVICE_UNAVAILABLE_ERROR, consumer=_consumer) | ||
| return kwargs | ||
| def __getattr__(name: str): |
Member
There was a problem hiding this comment.
We should add __all__ and __dir__ since star imports and dir(models) no longer include lazy model classes. this applies to all the generated clients
kuhe
marked this pull request as draft
October 30, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on smithy-lang/smithy-python#874