Normalize connection URL whitespace#1982
Merged
Merged
Conversation
kmcginnes
self-requested a review
July 23, 2026 20:27
5 tasks
kmcginnes
marked this pull request as ready for review
July 23, 2026 22:47
kmcginnes
approved these changes
Jul 23, 2026
kmcginnes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this! I'm assuming based on your comments and description that you did not intend to leave this in draft. Merging, as this cleanly delivers the form-side of #1978 (strip newlines + trim on submit).
For context: this normalizes on submit, so it cleans a connection when the user re-saves it. The complementary read-path fix has already landed in main via #1998. That moves normalization into normalizeConnection, so connections already persisted with whitespace/newlines (including the graph-db-connection-url proxy header) are cleaned on read without needing a re-save.
The two compose: your form-layer fix gives immediate validation feedback, and the read-layer fix covers the installed base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validation
pnpm checkssuccessfully.pnpm testsuite successfully: 191 test files and all 2,220 tests passed.Before
The saved URL retains surrounding whitespace and a newline:
After
The saved URL is normalized into a clean single line:
Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.