docs: align HMA supported-regions list with _helpers.tpl region map#433
Open
ibrahimnd2000 wants to merge 1 commit into
Open
docs: align HMA supported-regions list with _helpers.tpl region map#433ibrahimnd2000 wants to merge 1 commit into
ibrahimnd2000 wants to merge 1 commit into
Conversation
The supported-regions documentation in readme.md and the HMA chart values.yaml lagged behind the actual region->ECR-account map in _helpers.tpl. eu-south-2, ap-southeast-3, ap-southeast-4, and ca-central-1 are rendered correctly by the chart but were missing from the docs; the values.yaml fallback note also said us-west-2 while the code falls back to us-east-1. Sync both to the 17-region map.
ibrahimnd2000
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported-regions documentation in readme.md and the HMA chart values.yaml lagged behind the actual region->ECR-account map in _helpers.tpl. eu-south-2, ap-southeast-3, ap-southeast-4, and ca-central-1 are rendered correctly by the chart but were missing from the docs; the values.yaml fallback note also said us-west-2 while the code falls back to us-east-1. Sync both to the 17-region map.
What's changing and why?
Before/After UX
Before:
After:
How was this change tested?
Are unit tests added?
Are integration tests added?
Reviewer Guidelines
One of the following must be true: