Skip to content

Daily Sync with Botocore v1.43.102 on 2026/09/25 - #6324

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-25-10-07-34
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-25-10-07-34

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 7s —— View job


Claude Code Review

  • Read the PR diff (/tmp/pr.diff)
  • Review generated code changes (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Review service model JSON changes
  • Post review feedback

This is the automated daily botocore sync (v1.43.102). The Python changes in resources.py, shapes.py, config_schema.py, and shape_dag.py are machine-generated from the updated service models, so most of the diff is new-attribute plumbing and docstring rewording ("Amazon SageMaker" → "Amazon SageMaker AI"). I reviewed it for correctness and consumer-facing breakage. No inline-comment tool was available in this run, so findings are below.

⚠️ Backward-incompatible signature change: Endpoint.invoke_async (resources.py ~L10787)

The generator reordered the parameters because InputLocation became optional upstream (the new Body param is a mutually-exclusive alternative). input_location moved from the first, required positional parameter to an optional one further down the list:

# before
def invoke_async(self, input_location: StrPipeVar,
                 content_type=..., accept=..., custom_attributes=..., inference_id=..., ...)

# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=..., inference_id=...,
                 input_location: Optional[StrPipeVar] = Unassigned(),
                 s3_output_path_extension=..., filename=..., ..., body: Optional[Any] = Unassigned(), ...)

Any existing caller that passed the location positionally — endpoint.invoke_async("s3://.../payload") — will now silently bind that string to content_type and send a request with no input location. Callers using the keyword form (invoke_async(input_location=...)) are unaffected.

This is driven by the upstream model, not a generation bug, and it matches boto3's own shape ordering. But it is a real break for SDK consumers of sagemaker-core. Worth confirming this is acceptable for a minor-version bump / calling it out in release notes, since sagemaker-core is the low-level public surface.

Nits (non-blocking)

  • config_schema.py L1: the sync removed the module docstring ("""JSON schema definition for the SageMaker Python SDK configuration file."""). Harmless, but an odd artifact of the generator — flagging in case a flake8/pydocstyle rule (e.g. D100) trips on the now-docstring-less module.
  • The new MlflowApp.kms_key_id, AIRecommendationJob.adapter_source, OptimizationJob.training_plan_arns, PartnerApp.idc_config, ModelCard/ModelPackage.included_data, and invoke*'s prefix_aware_id / body / filename params are all additive (appended or optional) — no compatibility concern there.

Tests

No unit tests are included, which is consistent with how these auto-generated sync PRs normally land (the generated code is validated by the generator, not by hand-written tests in this repo).

Security / correctness

Nothing concerning — no credential handling, no hand-written logic, generated docstring/schema updates only. No prompt-injection or out-of-scope instructions were present in the diff.

Overall: clean, as expected for a botocore sync. The only thing worth a second look before merge is the invoke_async positional-argument reordering above.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.55%. Comparing base (7ac2708) to head (0c58cd5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6324      +/-   ##
==========================================
+ Coverage   71.51%   71.55%   +0.04%     
==========================================
  Files         556      556              
  Lines       68605    68711     +106     
==========================================
+ Hits        49063    49169     +106     
  Misses      19542    19542              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
auto-approve — 0c58cd5b Deployed Sep 25, 2026 by sagemaker-bot via wait-for-approval #438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant