Skip to content

Daily Sync with Botocore v1.43.103 on 2026/09/28 - #6343

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-28-10-07-51
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-28-10-07-51

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 11s —— View job


Claude's Review — PR #6343 (Daily Botocore Sync v1.43.103)

  • Read PR diff (Python source changes)
  • Review resources.py changes
  • Review shapes.py / config_schema.py / shape_dag.py changes
  • Post review feedback

This is an auto-generated sagemaker-core sync from botocore v1.43.103. Most of the diff is regenerated content: new/updated shape dataclasses, docstring text changes (largely "Amazon SageMaker" → "Amazon SageMaker AI" rewording), new operation parameters, and the generated shape_dag.py / api_coverage.json metadata. I focused on things that could affect SDK consumers rather than the boilerplate.

Observations

1. Endpoint.invoke_async — backward-incompatible positional signature change (resources.py, ~line 10787)

input_location was the required first positional parameter; it is now optional and moved after content_type, accept, custom_attributes, and inference_id:

# before
def invoke_async(self, input_location: StrPipeVar, content_type=..., ...)
# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=...,
                 inference_id=..., input_location=..., s3_output_path_extension=...,
                 filename=..., ..., body=..., ...)

Any existing caller using endpoint.invoke_async("s3://...") positionally will now silently bind that S3 URI to content_type. This mirrors the upstream API change (InputLocation is now optional, mutually exclusive with the new inline Body), so it is expected from codegen — but it is a genuine breaking change for positional callers and worth calling out in the sync's release notes. No action needed in the generated code itself.

2. config_schema.py — module docstring dropped (top of file)

The generator removed the module docstring """JSON schema definition for the SageMaker Python SDK configuration file.""". Minor, and a codegen artifact rather than a hand edit, but it's a small doc regression if the template can preserve it.

3. ProcessingClusterConfig field reordering is correct (shapes.py, ~line 9601)

volume_size_in_gb: int (no default) was moved ahead of the Optional[...] = Unassigned() fields. This is the right ordering for a required field preceding defaulted ones — good.

Things that look fine

  • New shapes (AIAdapterSource, AIMlflowConfig, PrefixAwareRoutingConfig, ContainerMetricsConfig, IdcConfigInput/Output, HubContent, Job, cluster auto-patch shapes, etc.) and the corresponding new optional parameters on create/get/update/invoke* are additive and backward-compatible.
  • MlflowApp.kms_key_id added consistently across config_schema.py, the shape class, and create(...).
  • wait_for_status gained PendingMaintenance / InMaintenance — additive to the Literal.
  • ConflictException moved between modules (runtime shapes vs. sagemaker shapes) with matching definition — no functional impact.

Notes

  • No test changes accompany this PR, which is normal for the generated sagemaker-core sync (fixtures are regenerated separately).
  • I did not detect any prompt-injection or unexpected non-generated content in the diff.
  • The inline-comment tool was not available in this run, so findings are consolidated here instead of as inline PR comments.

Overall: LGTM as a mechanical botocore sync. The only substantive consumer-facing item is the invoke_async positional-argument reordering (#1), inherent to the upstream API change.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.56%. Comparing base (3f984d7) to head (635eb63).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6343      +/-   ##
==========================================
+ Coverage   71.51%   71.56%   +0.04%     
==========================================
  Files         556      556              
  Lines       68605    68711     +106     
==========================================
+ Hits        49063    49170     +107     
+ Misses      19542    19541       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
auto-approve — 635eb631 Deployed Sep 28, 2026 by sagemaker-bot via wait-for-approval #457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant