Fix overload selection for a false argument - #1085
Merged
Merged
Conversation
is-congruent? derived the argument class with (when arg ...), so false read as nil and only the non-primitive overload matched. (Boolean. false) and (Boolean/valueOf false) then picked the String overload and threw ClassCastException. Use when-some, like the Java Reflector's null check.
The native test binary reads its options as edn, so a Class in :classes cannot cross that boundary. String is a default class, and (String/valueOf false) hit the same bug, so that form runs on both. The Boolean forms stay JVM-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is-congruent? derived the argument class with (when arg ...), so false read as nil and only the non-primitive overload matched. (Boolean. false) and (Boolean/valueOf false) then picked the String overload and threw ClassCastException. Use when-some, like the Java Reflector's null check.