Add list widget types

[olafgrabienski]

At the moment Reference provides one widget type: Autocomplete. That's often fine but there are also situations where it's more useful to show an editor a select list or checkboxes/radios to choose from. It would be nice if these options could be provided by Reference.

Here a screenshot of the requested widget as it is present in References:

[jenlampton]

There's a PR for this, coming soon if not somewhere in the queue already.

[mikemccaffrey]

This is the pull request submitted by @moonray: #26

I'm currently mentally unraveling it to see what it is doing.

[bradbulger]

+1 for this. In all the times I've used entity reference fields over the years, very few of them have been with autocomplete widgets. I suppose it's something that could be worked around in custom code, but that reduces the module's usefulness quite a bit. I'd think this plus the use of reference view displays for selection choices will be a requirement for most people looking to move out of Drupal 7.

[philsward]

What's the status on this? I pulled the whole reference.module from #26 and it looks like it will work as advertised. Does it still need work or does the reference module just need a new version release?

[jenlampton]

This issue is still open and the old PR was not merged. The PR needs to be rebased (or rewritten) against the current state of the module to move this issue forward.

…

On Tue, Sep 28, 2021, 5:31 PM philsward ***@***.***> wrote: What's the status on this? I pulled the whole reference.module from #26 <#26> and it looks like it will work as advertised. Does it still need work or does the reference module just need a new version release? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBER63TE3MUFF4DFZ677DUEJM6LANCNFSM4DTBM2ZQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[philsward]

Thanks @jenlampton

I'll run with #26 for the time being unless I run into issues. Yes, I understand this will break if an update rolls through where this hasn't been included.

So far no gotchas but I also don't have much time with it.

A quick rebase and potential commit shouldn't be far off.

[jenlampton]

I've pushed up a new PR with the changes from #26 as applied to the current state of things, but I expect it will need some work.

[olafgrabienski]

I've pushed up a new PR (...), but I expect it will need some work.

I've applied the PR to my test page, and I guess you're right, it's not yet working: When I change the widget of a Reference field to "Select list" or to "Check boxes/radio buttons" and try to edit an item with the field, I get a PDOException and an error page including some notices:

Notice: Undefined variable: base_table in reference_query() (line 474 of /.../reference-1.x-1.x/reference.module).
Notice: Undefined variable: keys in reference_query() (line 475 of /.../reference-1.x-1.x/reference.module).		
Notice: Undefined variable: keys in reference_query() (line 476 of /.../reference-1.x-1.x/reference.module).

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'AS , bt. AS `bt_` FROM `` bt ORDER BY ASC' at line 1: SELECT bt. AS , bt. AS `bt_` FROM {} bt ORDER BY ASC; Array ( ) in reference_query() (line 499 of /.../reference-1.x-1.x/reference.module).