feat(streams-bootstrap): add KEDA triggers and scaling modifiers - #659
Open
raphala wants to merge 4 commits into
Open
feat(streams-bootstrap): add KEDA triggers and scaling modifiers#659raphala wants to merge 4 commits into
raphala wants to merge 4 commits into
Conversation
raphala
marked this pull request as ready for review
August 6, 2026 15:17
tobbber
approved these changes
Aug 7, 2026
There was a problem hiding this comment.
Pull request overview
Adds first-class support for configuring KEDA autoscaling behavior (explicit triggers, additional triggers, and composite metric scaling modifiers) for streams-bootstrap-based apps, and updates the generated schema/docs and tests accordingly.
Changes:
- Extend
StreamsAppAutoScalingto supporttriggers(override generated Kafka lag triggers) andscaling_modifiers(KEDA composite metrics). - Add/expand tests for autoscaling trigger and scaling modifier generation for StreamsApp and ConsumerApp.
- Update JSON schemas and documentation examples/defaults to reflect the new autoscaling fields and semantics.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/components/streams_bootstrap/test_streams_app.py | Adds generation tests for triggers, additionalTriggers, and scalingModifiers in StreamsApp autoscaling values. |
| tests/components/streams_bootstrap/test_consumer_app.py | Adds generation test for triggers + scalingModifiers in ConsumerApp autoscaling values. |
| kpops/components/streams_bootstrap/common/model.py | Extends the autoscaling model with triggers, typed additional_triggers, and scaling_modifiers. |
| docs/docs/schema/pipeline.json | Updates published schema: additionalTriggers item type and adds triggers/scalingModifiers fields and descriptions. |
| docs/docs/schema/defaults.json | Mirrors pipeline schema updates for defaults schema output. |
| docs/docs/resources/pipeline-defaults/defaults.yaml | Updates default examples for consumer-app and streams-app autoscaling fields and comments. |
| docs/docs/resources/pipeline-defaults/defaults-streams-app.yaml | Updates streams-app defaults example to include triggers/additionalTriggers/scalingModifiers guidance. |
| docs/docs/resources/pipeline-defaults/defaults-consumer-app.yaml | Updates consumer-app defaults example to include triggers/additionalTriggers/scalingModifiers guidance. |
| docs/docs/resources/pipeline-components/streams-app.yaml | Updates streams-app component example values for the new autoscaling fields. |
| docs/docs/resources/pipeline-components/sections/values-streams-app.yaml | Updates streams-app values section snippet for the new autoscaling fields. |
| docs/docs/resources/pipeline-components/sections/values-consumer-app.yaml | Updates consumer-app values section snippet for the new autoscaling fields. |
| docs/docs/resources/pipeline-components/pipeline.yaml | Updates pipeline example(s) for consumer-app and streams-app autoscaling values. |
| docs/docs/resources/pipeline-components/consumer-app.yaml | Updates consumer-app component example values for the new autoscaling fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+168
to
173
| triggers: SerializeAsOptional[list[dict[str, Any]]] = [] | ||
| additional_triggers: SerializeAsOptional[list[dict[str, Any]]] = [] | ||
| scaling_modifiers: dict[str, Any] | None = None | ||
|
|
||
| model_config: ClassVar[ConfigDict] = ConfigDict(extra="allow") | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.