Skip to content

Fix type errors in the autoscaling model - #661

Closed
mzmbq wants to merge 4 commits into
mainfrom
fix/autoscaling
Closed

Fix type errors in the autoscaling model#661
mzmbq wants to merge 4 commits into
mainfrom
fix/autoscaling

Conversation

@mzmbq

@mzmbq mzmbq commented Aug 5, 2026

Copy link
Copy Markdown

Fixes #660:

  1. Fixes the incorrect type for additionalTriggers.
  2. Adds a pydantic.field_serializer to convert lagThreshold to str.

@mzmbq
mzmbq requested a review from disrupted as a code owner August 5, 2026 12:27
jnsrnhld
jnsrnhld reviewed Aug 5, 2026
View reviewed changes
Comment thread kpops/components/streams_bootstrap/common/model.py
@disrupted

disrupted commented Aug 11, 2026

Copy link
Copy Markdown
Member

in its current state duplicate of #659

@disrupted disrupted closed this Aug 11, 2026
@disrupted
disrupted deleted the fix/autoscaling branch August 11, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsrnhld jnsrnhld jnsrnhld left review comments
@disrupted disrupted Awaiting requested review from disrupted disrupted is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type errors in the autoscaling model

3 participants

@mzmbq @disrupted @jnsrnhld