Skip to content

Repository navigation

test(policy): remove POLICY_DISPATCH_FIX skip from dispatch_inactive #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rayyan224 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(policy): remove POLICY_DISPATCH_FIX skip from dispatch_inactive #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501b7a4
test(policy): remove POLICY_DISPATCH_FIX skip from dispatch_inactive
rayyan224 Oct 22, 2026
a77ff3c
Merge remote-tracking branch 'origin/main' into chore/remove-policy-d…
rayyan224 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions LIVE_PRECOMPILE_TESTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,18 +186,7 @@ SKIP_ACTIVATE=POLICY_REGISTRY make fork-tests \
The inactive-dispatch tests (`test/unit/PolicyRegistry/dispatch_inactive.t.sol`)
also normalize the feature to inactive themselves, so they're correct under the
default run too; `SKIP_ACTIVATE` additionally validates the never-activated
baseline. One assertion (that an unknown selector is classified *before* the
activation gate rather than masked by `FeatureNotActivated`) encodes a fix that
isn't in the Rust impl yet, so it's gated behind `POLICY_DISPATCH_FIX`:

```bash
SKIP_ACTIVATE=POLICY_REGISTRY POLICY_DISPATCH_FIX=true make fork-tests \
ARGS="--match-contract PolicyRegistryDispatchInactive"
```

Run it that way against a build that carries the dispatch-ordering fix (e.g. via
the [patch] local-clone override below) to enforce the regression; leave it
unset against stock builds so the default run stays green.
baseline.

## When the precompiles update — the loop

Expand Down
4 changes: 1 addition & 3 deletions test/unit/PolicyRegistry/dispatch_inactive.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,8 @@ contract PolicyRegistryDispatchInactiveTest is PolicyRegistryTest {
}

/// @notice An unknown selector is classified, not masked by the activation gate.
/// @dev Gated behind `POLICY_DISPATCH_FIX`: stock builds still return `FeatureNotActivated` here
/// until the dispatch-ordering fix is in the pinned impl.
function test_dispatch_revert_unknownSelectorNotMaskedByActivation(bytes4 selector) public {
vm.skip(!(_forkMode() && vm.envOr("POLICY_DISPATCH_FIX", false)));
vm.skip(!_forkMode());
vm.assume(!_isKnownSelector(selector));
_ensureInactive();

Expand Down
Loading