Take the communiques out of the source tree - #623
Merged
Conversation
A public repo's source tree is not a mailbox. Both of these were memos addressed to BC3 Rails, checked in where BC3 Rails does not read, and left to sit — the inline-attachments one since March. COMMUNIQUE-card-step-partial-updates.md also carries verbatim Ruby from the private bc3 repo (steps_controller.rb, kanban/cards_controller.rb) in a repo anyone can clone. Its ask succeeded and shipped as bc3#12521, so it has no remaining function either way. COMMUNIQUE-inline-attachments-api.md is clean of private source but equally misplaced, and its ask is still open. Both asks are now filed where their recipients are: bc3#12541 (upload file replacement, the real blocker on #404) and bc3#12542 (structured inline-attachment metadata). bc3 is private, so the Ruby excerpts are appropriate at that destination — which is what makes it the right home. Deleting from HEAD does not unpublish either file. Git history keeps them and they stay fetchable by SHA. A history rewrite is not this PR's call to make; if anyone judges one warranted, that goes to whoever owns bc3 and security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public repo's source tree is not a mailbox. Both files were memos addressed to BC3 Rails, checked in where BC3 Rails does not read, and left to sit — the inline-attachments one since March.
Why now
COMMUNIQUE-card-step-partial-updates.mdcarries verbatim Ruby from the privatebc3repo (steps_controller.rb,kanban/cards_controller.rb) in a repo anyone can clone. Its ask succeeded and shipped as bc3#12521, so it has no remaining function either way.COMMUNIQUE-inline-attachments-api.mdis clean of private source but equally misplaced, and its ask is still open — so it does not get deleted silently.Both asks are filed where their recipients are
basecamp files versions(Add basecamp files versions — HELD, blocked on the SDK #622) is held.bc3 is private, so the Ruby excerpts are appropriate at that destination. That is exactly what makes it the right home rather than here.
The CLI-side symptom of the versions-decoding defect went to the SDK issue that already covers it — basecamp/basecamp-sdk#649 — rather than a duplicate.
What this does not do
Deleting from HEAD does not unpublish either file. Git history keeps them and they stay fetchable by SHA. This PR does not rewrite history and does not claim to. If anyone judges a rewrite warranted, that decision belongs to whoever owns bc3 and security, not to this PR.
Nothing in the tree references either file (
rg COMMUNIQUEis clean outside the files themselves).bin/cigreen.Summary by cubic
Removed two misplaced communiqués (
COMMUNIQUE-card-step-partial-updates.md,COMMUNIQUE-inline-attachments-api.md) from the public repo to keep privatebc3code and requests in the right place. Both asks are now tracked in privatebc3issues; nothing referenced these files, so there are no behavior changes.Written for commit eb4cd60. Summary will update on new commits.