Skip to content

Stop adding a HEY row to the Omarchy menu - #509

Merged
robzolkos merged 1 commit into
mainfrom
stop-adding-omarchy-menu-row
Sep 27, 2026
Merged

robzolkos merged 1 commit into
mainfrom
stop-adding-omarchy-menu-row

Conversation

@dhh

@dhh dhh commented Sep 26, 2026

Copy link
Copy Markdown
Member

hey setup omarchy (and the full hey setup wizard) wrote a marker-delimited HEY row into ~/.config/omarchy/extensions/omarchy-menu.jsonc. The Omarchy menu belongs to the user and Omarchy, so hey shouldn't add to it.

  • Setup no longer writes a menu row. The block builder and inserter are deleted.
  • Setup takes out the block earlier releases wrote, leaving the rest of the file byte for byte, and reports the menu only when it removed something.
  • --remove still strips the block.
  • The command help, the wizard's summary line and docs/omarchy.md no longer mention a menu row.

Tests

  • Setup never creates or edits the menu file, and leaves an existing user file untouched.
  • A new test seeds an earlier HEY block beside user rows and comments. Setup removes only the block and reports removed, a second run says nothing about the menu, and --remove on the clean file reports absent.
  • go test ./... passes.

🤖 Generated with Claude Code

The Omarchy menu belongs to the user and Omarchy. hey setup omarchy no
longer writes a row into ~/.config/omarchy/extensions/omarchy-menu.jsonc,
and it takes out the marker block earlier releases added, leaving the
rest of the file untouched. --remove still strips it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh
dhh requested a review from a team as a code owner September 26, 2026 21:27
Copilot AI balanced review requested due to automatic review settings September 26, 2026 21:27

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform pattern review found no security or privacy issues in the changed lines. Setup no longer writes the Omarchy menu and only removes a prior marker-delimited block; that is a local config cleanup, not an unauthenticated route, identity, TLS, logging, or HTML/CSP change.

Open in Web View Automation 

Sent by Cursor Security Agent: Security Reviewer

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

The focused implementation matches the stated behavior and includes appropriate regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Stops Omarchy setup from adding a HEY menu row while removing legacy managed rows safely.

Changes:

  • Removes menu-row installation logic.
  • Cleans up legacy managed menu blocks.
  • Updates tests, help text, wizard output, and documentation.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
internal/​cmd/​setup.go Updates the wizard summary.
internal/​cmd/​omarchy.go Removes menu installation and performs legacy cleanup.
internal/​cmd/​omarchy_test.go Tests menu preservation and legacy removal.
docs/​omarchy.md Documents the revised integration behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@robzolkos
robzolkos merged commit 24c9902 into main Sep 27, 2026
26 checks passed
@robzolkos
robzolkos deleted the stop-adding-omarchy-menu-row branch September 27, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants