fix(cli): replace retired Basic Memory links#1083
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The link fixes proposed in #1026 are valid, but that external-contributor PR remains blocked on the CLA. This is an independent maintainer implementation; no contributor commit was copied.
The retired documentation paths and subscription URL return 404s. The CLI also retained the retired subscription URL as its fallback when the cloud API omits a
subscribe_url.What changed
subscribe_urlfallbackServer-provided subscription URLs still take precedence.
Validation
uv run pytest tests/cli/test_cloud_authentication.py -q— 10 passedjust fast-checkRisk
Low. The runtime change only affects the fallback URL when the cloud API does not provide one.
Supersedes #1026.