Repository navigation
fix(core): upgrade FastAPI and preserve read-cache identities - #1854
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
phernandez
force-pushed
the
chore/fastapi-python315
branch
2 times, most recently
from
October 24, 2026 16:49
5dba8dd to
28867fd
Compare
phernandez
force-pushed
the
chore/fastapi-python315
branch
from
October 24, 2026 16:54
28867fd to
c09b2c1
Compare
Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
force-pushed
the
chore/fastapi-python315
branch
from
October 24, 2026 17:06
c09b2c1 to
2e59e90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upgrade FastAPI from 0.139.0 to 0.162.0 while preserving local MCP startup and read-cache identity. The new FastAPI removes
get_flat_dependant, which previously prevented Basic Memory from importing after the upgrade.Stacked on #1849; land that migration first, then retarget this PR to main.
What Changed
uv.lock.docs/1.0.md.Implementation Details
Cache keys retain all declared nested query inputs and normalize request bodies through their Pydantic model. FastMCP stays at 4.1.3, already the latest stable release checked. Python support and CI remain 3.12–3.14: even latest ONNX Runtime 1.31.0 lacks Python 3.15 wheels. Local embeddings remain in the default installation.
Testing
BASIC_MEMORY_ENV=test uv run pytest tests --no-cov -q -n 4— 8,780 passed, 81 skipped.BASIC_MEMORY_ENV=test uv run pytest test-int/mcp test-int/read_cache -m 'not benchmark' --no-cov -q— 400 passed, 1 deselected.BASIC_MEMORY_ENV=test BASIC_MEMORY_TEST_POSTGRES=1 uv run pytest tests/test_read_cache_request_identity.py tests/api/v2/test_project_router.py test-int/mcp/test_adapter_project_routing.py test-int/read_cache/test_cache_rules.py --no-cov -q— 60 passed.UV_PROJECT_ENVIRONMENT=/tmp/bm-fastapi-py312 UV_PYTHON=3.12 uv run pytest tests/test_read_cache_request_identity.py tests/api/v2/test_project_router.py test-int/mcp/test_adapter_project_routing.py --no-cov -q— 41 passed on Python 3.12.just typecheck,just package-check,just doctor, targeted Ruff lint/format checks,uv lock --checkandgit diff --check— passed.Risks / Follow-ups
The lockfile updates Logfire to 5.3.0 with OpenTelemetry 1.45.1 to satisfy FastAPI's newer dependency requirements; telemetry and package tests passed. Full PostgreSQL coverage remains a CI gate. FastEmbed/ONNX Runtime upgrades are separate work and would not unblock Python 3.15 today; track microsoft/onnxruntime#33271.