Repository navigation
fix(mcp): align recovery guidance and manuals with bm tools - #1868
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cloud now exposes only the
bm_*1.0 tools, but core recovery messages still told agents to call removed tools, sometimes with unsupported parameters such asproject_id. The bundled read manual also omitted Cloud's hosted read options.What Changed
bm_read,bm_write,bm_edit,bm_delete,bm_search,bm_move,bm_list, andbm_contextin recovery guidance, API conflict messages, prompt templates, and cross-tool help.project,command,mode,items,since,path, anddestination). Preserve external project IDs in recovery calls to avoid ambiguous project names.versions,version,cursor,view, andreview_modeoptions, defaults, and incompatible combinations inbm-read(3).bm_*tool, including tools hidden at startup.Implementation Details
Core's
bm_readdoes not accept Cloud's five additional parameters. The manual therefore retains its generated core SYNOPSIS/PARAMETERS and documents a separate hosted signature and Cloud parameters, checked againsthosted_bm_readin the Cloud repository. No Cloud-only behavior is added to the local tool.Legacy compatibility tool implementations and their wire names remain intact. Their recovery guidance now points agents to the public tool surface; creating a missing note recommends
bm_writebecausebm_editnever creates notes.The new manual guard inspects exported Python signatures instead of the visible registry, so optional project-deletion tools cannot silently escape coverage.
Testing
uv run pytest tests/api/v2/test_prompt_router.py tests/api/v2/test_knowledge_router.py -k 'prompt or conflict or exists' --import-mode=importlib -q -o addopts= --tb=short: 9 passed.just fast-check: passed (Ruff checks/formatting and full typecheck).just doctor: passed, including sandboxed write/index/search.git diff --check: passed.Combined suite command:
Risks / Follow-ups
Changes primarily affect guidance and documentation; JSON edit conflicts gain an additive
messagefield. Cloud-only documentation is curated from the hosted wrapper, while automated signature coverage checks the core tools shipped by this repository. SQLite was exercised locally; the PR matrix covers the remaining platforms and Postgres.