Potential fix for code scanning alert no. 1: Clear-text storage of sensitive information - #15
Open
karlspace wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 1: Clear-text storage of sensitive information#15karlspace wants to merge 1 commit into
karlspace wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
karlspace
marked this pull request as ready for review
September 1, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/bauer-group/XPD-RPIImage/security/code-scanning/1
To fix this without changing overall functionality (users still get configured), stop embedding plaintext passwords in generated files. The best approach here is:
$6$...SHA-512 crypt format).chpasswd -elines using the hash, not plaintext.In
scripts/generate.py, update the user creation block around lines 453–474:passwordkey to avoid schema/functionality break).$id$).echo name:pw | chpasswdwithecho name:hash | chpasswd -e.No new imports are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.