Skip to content

feat: updates to the py_extension rule for building C extensionsPy extension #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsartor-cmd wants to merge 27 commits into
base: py-extension
Choose a base branch
from
Open

feat: updates to the py_extension rule for building C extensionsPy extension #3875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8214422
Don't leave a trailing slash for the root package.
rsartor-cmd Jun 26, 2026
1e89b99
Remove duplicate assignment.
rsartor-cmd Jun 26, 2026
d921d20
Remove typical C-style integer suffixes before parsing.
rsartor-cmd Jun 26, 2026
f318173
Fix check for filename.
rsartor-cmd Jun 26, 2026
80a9aae
Remove unnecessary guard.
rsartor-cmd Jun 26, 2026
9bfc331
Re-format docstring.
rsartor-cmd Jun 26, 2026
e85e06b
Get the platform from the constraints.
rsartor-cmd Jun 29, 2026
590b667
Adjust formatting syntax.
rsartor-cmd Jun 29, 2026
15c95f8
Change the default value.
rsartor-cmd Jun 29, 2026
daa2455
Add more test cases for py_limited_api.
rsartor-cmd Jun 29, 2026
030c879
Use RunfilesBuilder instead of manual.
rsartor-cmd Jun 29, 2026
73eb7c0
Add abi_tag to PyCcToolchainInfo.
rsartor-cmd Jun 30, 2026
5cb7c90
Use the PyCcToolchainInfo to derive the filename instead of the runti…
rsartor-cmd Jun 30, 2026
797bf98
Remove the fallback. Determine platform tag solely from constraints.
rsartor-cmd Jun 30, 2026
09a2e0a
Remove the version compatibility check, as it has performance implica…
rsartor-cmd Jun 30, 2026
5bbe09f
Fix header filename.
rsartor-cmd Jun 30, 2026
475ed3d
Update python/private/cc/py_extension_rule.bzl
rsartor-cmd Jun 30, 2026
903c96a
ruff
rsartor-cmd Jun 30, 2026
9570a98
Derive the values for the _constraints attr programmatically, instead…
rsartor-cmd Jun 30, 2026
7179c8a
Take glibc-vs-musl into account, so we get the right platform and name.
rsartor-cmd Jun 30, 2026
b353be6
Clean up as per the linter.
rsartor-cmd Jun 30, 2026
ee6395d
Remove print()s per buildifier.
rsartor-cmd Jun 30, 2026
8d80783
Remove unused variable (buildifier).
rsartor-cmd Jun 30, 2026
451ea48
Sort keys [buildifier]
rsartor-cmd Jun 30, 2026
a40ae2b
Remove print()s per buildifier.
rsartor-cmd Jun 30, 2026
90ad765
Remove unused load().
rsartor-cmd Jun 30, 2026
708dac4
Call out unused parameters [buildifier]
rsartor-cmd Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/private/cc/py_extension_macro.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ def py_extension(**kwargs):
if use_csl:
_py_extension_csl(**kwargs)
else:
if "libc" not in kwargs:
kwargs["libc"] = select({
"//conditions:default": "glibc",
"@rules_python//python/config_settings:_is_py_linux_libc_glibc": "glibc",
"@rules_python//python/config_settings:_is_py_linux_libc_musl": "musl",
})
_py_extension(**kwargs)

def _py_extension_csl(*, name, module_name = None, **kwargs):
Expand Down
Loading
Loading