chore(release): various fixes to release tool and workflows#3880
Conversation
This fixes a bug where local out-of-sync tags could lead to computing the wrong next RC version. We now query remote tags directly using git ls-remote. Also added type annotations and docstring to get_remote_tags.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to query git tags directly from a remote repository using git ls-remote to ensure release candidate versions are determined from the latest remote state. The feedback suggests adding a safety check in get_remote_tags to prevent an AttributeError if run_cmd returns None or an empty string, and refactoring cmd_promote_rc to fetch remote tags before calling determine_next_version to avoid relying on stale local tags.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
rickeylev
changed the title
rickeylev
changed the title
rickeylev
changed the title
Excludes the "release" directory from the version checks
1 participant
The release tool previously calculated incorrect RC versions or failed when local tags were out of sync with the remote repository.
To resolve this:
git ls-remoteto determine the next RC version.promote-rcto avoid stale local state.create-rcto simplify the tagging process.