chore(release): pass missing --remote argument to release workflows#3883
Conversation
Workflows using `process-backports` and `promote-rc` subcommands were failing due to missing or hardcoded remote arguments. - Added `--remote` parameter to `promote-rc` subcommand. - Updated `release_process_backports.yaml` and `release_promote_rc.yaml` to pass `--remote origin`. - Updated tests in `release_test.py` to support and verify the new argument.
rickeylev
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the promote-rc subcommand to accept a --remote command-line argument instead of hardcoding the git remote to 'upstream', and updates the corresponding unit tests. Feedback suggests making --remote optional with a default value of 'upstream' to maintain backwards compatibility, and updating the dry-run output message to use the configured remote instead of hardcoding 'upstream'.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Tag the specific commit without checkout, and push to remote | ||
| self.git.tag(version, commit_sha) | ||
| self.git.push("upstream", version) | ||
| self.git.push(args.remote, version) |
There was a problem hiding this comment.
While updating the push command to use args.remote instead of the hardcoded 'upstream', please also update the dry-run message on line 79 (print(f"[DRY RUN] Would push tag {version} to upstream")) to use args.remote as well, ensuring consistency between dry-run output and actual execution.
1 participant
Workflows using
process-backportsandpromote-rcsubcommands were failingdue to missing or hardcoded remote arguments.
--remoteparameter topromote-rcsubcommand.release_process_backports.yamlandrelease_promote_rc.yamltopass
--remote origin.release_test.pyto support and verify the new argument.