Fix local_includes with implementation_deps - #793
Open
keith wants to merge 2 commits into
Open
Conversation
This separate codepath was missing this attr bazelbuild@ab84bd3
keith
referenced
this pull request
Jul 17, 2026
Copybara Import from #556 BEGIN_PUBLIC Add local_includes to cc_library / cc_binary (#556) This new attribute solves one of the longstanding annoyances with private include paths for third party projects. Today users often hardcode `-Iexternal/something` or come up with some complicated workarounds with custom rules vending make variables or `implementation_deps` This attribute is named after, and has the same semantics, as `defines` vs `local_defines`. These paths are only used in the context of the rule that they are on. Fixes bazelbuild/bazel#16472 Fixes bazelbuild/bazel#24144 Closes #556 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#556 from keith:ks/add-local_includes-to-cc_library-cc_binary 6654c39 PiperOrigin-RevId: 915078923 Change-Id: Ie4ca0847e14c7bf1d4038b463dc4d3c29c36d405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separate codepath was missing this attr
ab84bd3