Replace the deprecated C++ compiler marker with None - #808
Open
dzbarsky wants to merge 2 commits into
Open
Conversation
dzbarsky
marked this pull request as ready for review
July 31, 2026 18:23
Collaborator
There was a problem hiding this comment.
Don't think we need to test for this.
Also; it appears we have a few (<5) files still checking this; should clean them up first.
Contributor
Author
There was a problem hiding this comment.
Are these internal usages? I didn't see them in this repo. (I did see https://github.com/protocolbuffers/protobuf/blob/b790ca9a4b222070d1d7cdf93c980ddeae8a55aa/build_defs/compiler_config_setting.bzl#L5-L25 and things like that but I think they will continue to work as they did, even with the None-valued attr?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Java-backed cc_common.do_not_use_tools_cpp_compiler_present marker with its existing Starlark value, None. Bazel declares the deprecated marker as a Java void struct field, so preserving the exported field with None removes the Java dependency without changing compatibility.
Validation: buildifier -mode=check and 24 passing //tests/cc/common:cc_common_tests cases.