Skip to content

Use Starlark dynamic-library symlinks in C++ linking - #810

Open
dzbarsky wants to merge 2 commits into
bazelbuild:mainfrom
dzbarsky:codex/starlarkify-linker-dynamic-symlinks
Open

Use Starlark dynamic-library symlinks in C++ linking#810
dzbarsky wants to merge 2 commits into
bazelbuild:mainfrom
dzbarsky:codex/starlarkify-linker-dynamic-symlinks

Conversation

@dzbarsky

@dzbarsky dzbarsky commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Route both remaining direct _cc_internal.dynamic_library_symlink calls in cc_linking_helper.bzl through the existing Starlark dynamic_library_symlink implementation. The existing implementation preserves artifact naming, symlink registration, and its compatibility fallback for older Bazel versions.

Update the ThinLTO symlink regression to accept the Starlark Symlink action mnemonic and the native SolibSymlink compatibility fallback.

Validation: buildifier -mode=check and 89 passing ThinLTO, C++ binary, and import analysis tests.

@dzbarsky
dzbarsky marked this pull request as ready for review July 31, 2026 18:24
@trybka

trybka commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

@lilygorsheneva does this conflict with your changes?

@lilygorsheneva

Copy link
Copy Markdown
Collaborator

@lilygorsheneva does this conflict with your changes?

I missed those two callsites when making my changes. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants