Support rustc incremental compilation via persistent workers - #4184
Draft
anguslees wants to merge 1 commit into
Draft
Support rustc incremental compilation via persistent workers#4184anguslees wants to merge 1 commit into
anguslees wants to merge 1 commit into
Conversation
Author
|
If you would rather I switch to using a protobuf library (and add more deps to the process wrapper), I can do that instead. |
anguslees
marked this pull request as draft
July 31, 2026 02:33
Add protobuf persistent-worker support to process_wrapper and opt-in incremental compilation for non-optimized Rustc actions. Flatten rustc response files through worker requests while preserving process_wrapper substitutions, and retain one-shot execution for opaque Args actions. Assisted-by: Kilo Code
anguslees
force-pushed
the
gus/persistent-rustc-workers
branch
from
August 10, 2026 07:59
1e07811 to
9dfe42a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_wrapper--@rules_rust//rust/settings:experimental_persistent_worker=truesettingWorkRequestas one rustc param fileArgsextension caseRelated to #412. This is a worker-local alternative to the Bazel-managed incremental artifacts proposed in #3925.
Test plan
bazel test //util/process_wrapper:process_wrapper_test --@rules_rust//rust/settings:experimental_persistent_worker=truebazel test //test/process_wrapper/... //test/unit/pipelined_compilation:pipelined_compilation_test_suite //test/unit/location_expansion:location_expansion_test_suite//test/unit/location_expansion:mylibrarywith nested response filesextra_rustc_flagbazel test --config=rustfmt //util/process_wrapper:process_wrapper_testbuildifier -mode=check rust/private/rust.bzl rust/private/rustc.bzl rust/settings/BUILD.bazel rust/settings/settings.bzlAI assistance
Kilo Code assisted with rebasing the original implementation onto current
main, compatibility review, and test iteration. I reviewed and own the resulting changes.