Skip to content

fix regressions in _prefix_pwd_to_flag in cargo_build_script.bzl - #4215

Open
KirillTim wants to merge 1 commit into
bazelbuild:mainfrom
KirillTim:kirilltim/fix_cargo_build_script
Open

fix regressions in _prefix_pwd_to_flag in cargo_build_script.bzl#4215
KirillTim wants to merge 1 commit into
bazelbuild:mainfrom
KirillTim:kirilltim/fix_cargo_build_script

Conversation

@KirillTim

@KirillTim KirillTim commented Aug 9, 2026

Copy link
Copy Markdown

also extract _pwd_flags_* functions to a list to improve readability.

Tested:

bazel test //cargo/tests/cargo_build_script/cc_args_and_env:all

also extract _pwd_flags_* functions to a list to improve readability
@google-cla

google-cla Bot commented Aug 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@KirillTim

Copy link
Copy Markdown
Author

While working on #4216, I noticed some regressions in the way we handle compiler flags. These aren't just theoretical corner cases; they can easily happen in standard use cases, so I decided to fix them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant