Repository navigation
#6586 - Batch reassessment outcome - #6742
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Concurrent requests can display stale results, and the failure-reason contracts exclude emitted null values.
4 open findings
What changed in this PR
Adds detailed, paginated batch reassessment results for ministry users, including filtering, statuses, and navigation to application assessments.
Changes:
- Adds the batch reassessment detail API, DTOs, filtering, pagination, and e2e coverage.
- Adds the results view, status chips, history actions, and navigation.
- Adds pending counts and application-level outcomes.
| File | Description |
|---|---|
sources/packages/web/src/views/aest/student/applicationDetails/AssessmentsSummary.vue |
Supports custom back navigation. |
sources/packages/web/src/views/aest/BatchReassessmentDetail.vue |
Adds the detailed results page. |
sources/packages/web/src/views/aest/BatchReassessment.vue |
Updates the input label. |
sources/packages/web/src/types/contracts/DataTableContract.ts |
Adds pending/action and detail table headers. |
sources/packages/web/src/types/contracts/BatchReassessment.ts |
Defines application result statuses. |
sources/packages/web/src/types/AppRoutes.ts |
Defines the detail route path. |
sources/packages/web/src/services/http/dto/BatchReassessment.dto.ts |
Adds pending counts and result DTO. |
sources/packages/web/src/services/http/BatchReassessmentApi.ts |
Adds the paginated detail request. |
sources/packages/web/src/services/BatchReassessmentService.ts |
Exposes detail retrieval to views. |
sources/packages/web/src/router/AESTRoutes.ts |
Registers detail and back-navigation routes. |
sources/packages/web/src/constants/routes/RouteConstants.ts |
Adds the detail route identifier. |
sources/packages/web/src/components/generic/StatusChipBatchReassessmentApplicationResult.vue |
Renders result status chips. |
sources/packages/web/src/components/aest/BatchReassessmentHistory.vue |
Adds pending counts and detail navigation. |
sources/packages/backend/apps/api/src/utilities/datatable-config.ts |
Defines detail pagination options. |
sources/packages/backend/apps/api/src/services/batch-reassessment/batch-reassessment.service.ts |
Queries and classifies application outcomes. |
sources/packages/backend/apps/api/src/services/batch-reassessment/batch-reassessment.service.models.ts |
Defines detail service models. |
sources/packages/backend/apps/api/src/route-controllers/models/pagination.dto.ts |
Validates result filtering and sorting. |
sources/packages/backend/apps/api/src/route-controllers/batch-reassessment/models/batch-reassessment.dto.ts |
Defines API output DTOs. |
sources/packages/backend/apps/api/src/route-controllers/batch-reassessment/batch-reassessment.aest.controller.ts |
Adds the detail endpoint. |
sources/packages/backend/apps/api/src/route-controllers/batch-reassessment/_tests_/e2e/batch-reassessment.aest.controller.getBatchReassessments.e2e-spec.ts |
Covers pending summary counts. |
sources/packages/backend/apps/api/src/route-controllers/batch-reassessment/_tests_/e2e/batch-reassessment.aest.controller.getBatchReassessmentApplications.e2e-spec.ts |
Covers detail retrieval, filtering, validation, and authorization. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
weskubo-cgi
marked this pull request as ready for review
October 14, 2026 22:12
weskubo-cgi
commented
Oct 14, 2026
Comment on lines
+176
to
+180
| query | ||
| .orderBy( | ||
| "batchApplication.applicationNumber", | ||
| paginationOptions.sortOrder ?? FieldSortOrder.ASC, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Search logic is kept simple as the only supported sortField (which is also the default) is applicationNumber.
weskubo-cgi
changed the title
dheepak-aot
self-requested a review
October 15, 2026 16:44
tiago-graf
self-requested a review
October 15, 2026 16:50
dheepak-aot
reviewed
Oct 15, 2026
dheepak-aot
reviewed
Oct 15, 2026
Comment on lines
+41
to
+42
| * applications were successfully reassessed, how many failed, and how many | ||
| * are still pending. |
dheepak-aot
reviewed
Oct 15, 2026
dheepak-aot
reviewed
Oct 15, 2026
dheepak-aot
reviewed
Oct 15, 2026
dheepak-aot
reviewed
Oct 15, 2026
dheepak-aot
reviewed
Oct 15, 2026
dheepak-aot
reviewed
Oct 15, 2026
Collaborator
|
Great work. Please take a look at the comments. |
dheepak-aot
reviewed
Oct 16, 2026
| searchCriteria: searchCriteria.value, | ||
| }; | ||
| if (selectedFilter.value !== ResultFilter.All) { | ||
| criteria.result = selectedFilter.value; |
tiago-graf
reviewed
Oct 16, 2026
| }); | ||
| if (paginationOptions.searchCriteria) { | ||
| query.andWhere("batchApplication.applicationNumber ILIKE :search", { | ||
| search: `%${paginationOptions.searchCriteria.trim()}%`, |
Collaborator
There was a problem hiding this comment.
Just a thought but if the searchCriteria is a whitespace " " wouldn't the trim make the search ILIKE '%%' ?
Collaborator
Author
There was a problem hiding this comment.
Good catch. I'll update the service.
tiago-graf
reviewed
Oct 16, 2026
| const BATCH_REASSESSMENT_NUMBER_SEQUENCE_NAME = "BATCH_REASSESSMENT_NUMBER"; | ||
| const BATCH_REASSESSMENT_CHUNK_SIZE = 1000; | ||
| /** | ||
| * Assessment statuses indicating the application was successfully reassessed, including cancellations in progress.. |
tiago-graf
reviewed
Oct 16, 2026
| :toggled="!paginatedApplications.count && !loading" | ||
| message="No applications found." | ||
| > | ||
| <v-data-table-server |
Collaborator
There was a problem hiding this comment.
Please check there if loadApplications is being call twice on mount. In theory the data table @update:options should trigger on mount (as well as the component onMount)
Collaborator
Author
There was a problem hiding this comment.
This is a known issue with lazily loaded data tables as captured in ZenHub #5457. I have put in a small fix that may be the solution moving forward.
added 2 commits
October 16, 2026 13:15
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
tiago-graf
approved these changes
Oct 16, 2026
E2E Queue Consumers Coverage Report
|
dheepak-aot
reviewed
Oct 16, 2026
| const application = batchApplication.studentAssessment?.application; | ||
| // The versions join is filtered to the current application only. | ||
| const [currentApplication] = | ||
| application?.parentApplication.versions ?? []; |
Collaborator
There was a problem hiding this comment.
Versions must not be null or empty and hence fallback is not required.
Collaborator
Author
There was a problem hiding this comment.
On closer analysis, the fallback isn't for versions but for application since not all reassessments have an application. And the destructuring will fail without it.
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Oct 16, 2026
dheepak-aot
left a comment
dheepak-aot
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making the changes. Looks good 👍Left a minor comment.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web
BatchReassessment.vuescreen.BatchReassessmentOutcome.vuescreen to view application level detailsAPI
Screenshots
Ministry -> Batch Reassessment
Ministry -> Batch Reassessment Outcome
Navigation to application after edit
E2E tests
BatchReassessmentAESTController(e2e)-getBatchReassessmentApplications
BatchReassessmentAESTController(e2e)-getBatchReassessments