Repository navigation
#404 - Cherry pick hotfix 4.2.1 to main - #6761
Open
sh16011993 wants to merge 8 commits into
Open
sh16011993 wants to merge 8 commits into
sh16011993 wants to merge 8 commits into
Conversation
**Summary** - Corrected the 2026–2027 full-time assessment DMN weekly MSOL allowance values for single students away from home, single parents, married students and spouses, and each dependent.
sh16011993
added
E2E/Unit tests
Branch Sync-up
sh16011993
marked this pull request as draft
October 16, 2026 15:49
sh16011993
changed the title
sh16011993
marked this pull request as ready for review
October 16, 2026 18:06
| assessmentConsolidatedData.parent1Contributions = 0; | ||
| assessmentConsolidatedData.parent1DependentTable = [ | ||
| createFakeStudentDependentEligibleForContribution({ | ||
| ...createFakeStudentDependentsEligibleForContribution({ |
Collaborator
There was a problem hiding this comment.
I do not see an array as a default pattern for the factory methods for dependents. Since it is a hotfix, we can execute the minimal E2E to cover the fix. That said, can you please consider the adjustment below to the factory to allow the scenarios below, which seems to be more expressive and easier to read?
Note: not all E2E scenarios need to test all of these, but it would be good if these variations below are included.
assessmentConsolidatedData.parent1DependentTable = [
// 15 years old attending post-secondary school (eligible for contribution).
createFakeStudentDependentsForContribution({
referenceDate: assessmentConsolidatedData.offeringStudyStartDate,
age: 15,
attendingPostSecondarySchool: YesNoOptions.Yes,
}),
// 15 years old attending not post-secondary school (not eligible for contribution).
createFakeStudentDependentsForContribution({
referenceDate: assessmentConsolidatedData.offeringStudyStartDate,
age: 15,
attendingPostSecondarySchool: YesNoOptions.No,
}),
// On the day completing 23 years old (not eligible for contribution).
createFakeStudentDependentsForContribution({
referenceDate: assessmentConsolidatedData.offeringStudyStartDate,
age: 23,
attendingPostSecondarySchool: YesNoOptions.Yes,
}),
// One day before completing 23 years old (eligible for contribution).
createFakeStudentDependentsForContribution({
referenceDate: assessmentConsolidatedData.offeringStudyStartDate,
age: 23,
attendingPostSecondarySchool: YesNoOptions.Yes,
daysOffSet: -1,
}),
];New factory method
* Creates student dependents at contribution eligibility age boundaries.
* @param options Options for constructing the dependent.
* - `referenceDate` Reference date used to calculate the dependents' birthdays.
* - `age` Age of the dependent.
* - `attendingPostSecondarySchool` Whether the dependent is attending post-secondary school.
* - `daysOffSet` Optional number of days to offset the dependent's birthday.
* @returns Dependents eligible for contribution based on their age and school attendance.
*/
export function createFakeStudentDependentsForContribution(options: {
referenceDate: Date | string;
age: number;
attendingPostSecondarySchool: YesNoOptions;
daysOffSet?: number;
}): StudentDependent {
let dateOfBirth = addToDateOnlyString(
options.referenceDate,
-options.age,
"years",
);
if (options.daysOffSet) {
dateOfBirth = addToDateOnlyString(dateOfBirth, options.daysOffSet, "day");
}
return {
dateOfBirth,
attendingPostSecondarySchool: options.attendingPostSecondarySchool,
// Not relevant for the contribution eligibility calculation.
declaredOnTaxes: YesNoOptions.No,
// Not relevant for the contribution eligibility calculation.
relationship: DependantRelationship.Child,
};
}
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, please take a look at the below comment and share your thoughts.
https://github.com/bcgov/SIMS/pull/6761/changes#r4298152262
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.