Repository navigation
#6560 - Upgrade NestJS and fix compatibility issues - #6762
Open
tiago-graf wants to merge 3 commits into
Open
tiago-graf wants to merge 3 commits into
tiago-graf wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The major framework and ESM upgrade needs build, test, startup, and worker-readiness validation before approval.
0 open findings
What changed in this PR
Upgrades the SIMS backend to NestJS 12.1.3 and adapts testing and worker health checks for compatibility.
Changes:
- Updates NestJS dependencies and adds explicit webpack tooling dependencies.
- Enables VM modules for Jest and skips dependency transformation.
- Migrates Zeebe health reporting to
HealthIndicatorServiceand adjusts a test-helper import.
| File | Description |
|---|---|
| sources/packages/backend/package.json | Updates dependencies and Jest commands. |
| sources/packages/backend/package-lock.json | Locks the updated dependency tree. |
| sources/packages/backend/jest-unit-tests.json | Excludes dependencies from transformation. |
| sources/packages/backend/jest-e2e.json | Applies the same exclusion to integration tests. |
| sources/packages/backend/apps/workers/src/zeebe/zeebe-health-indicator.ts | Uses Terminus up/down health results. |
| sources/packages/backend/apps/api/src/testHelpers/moked-http-contexts/http-context-mock.ts | Uses an explicit interface import path. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
E2E SIMS API Coverage Report
|
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade NestJS to 12.1.3.
Set NODE_OPTIONS=--experimental-vm-modules so Jest can load the ESM-only NestJS 12 packages.
zeebe-health-indicator.ts: Replaced the removed Terminus HealthIndicator and HealthCheckError with HealthIndicatorService and up/down results.