Load test updates - #255
Open
alitman-bcgov wants to merge 5 commits into
Open
Conversation
mtspn
requested changes
Aug 10, 2026
mtspn
left a comment
mtspn
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @alitman-bcgov , changes look great. Good that you updated the recommendations about settings limits here and improved the load test. Let's discuss the one section I commented on and make some changes before brining these changes in?
| This will cause the pod to re-deploy with updated resources. | ||
|
|
||
| If a resource quota applies to a resource request, then the pod should define a resource request. If a resource quota applies to a resource limit, then the pod should also define a resource limit. We recommend ALWAYS defining resource requests and limits for all workloads. | ||
| If a resource quota applies to a resource request, then the pod must define a resource request. If a resource quota applies to a resource limit, then the pod must also define a resource limit. We recommend always defining resource requests for all workloads. CPU limits are not required and are generally best left unset for performance reasons. Memory limits are also not required, but are a good idea to set. |
Collaborator
There was a problem hiding this comment.
This section needs some adjusting, as we don't have resource quotas for limits anymore. All resource quotas are based on request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the load test so that it runs for 20 minutes, to give lab participants enough time to get through all the instructions. Added in some additional clarifying instructions.
Also fixed:
-Some out-of-date references to CPU limits
-Added in a note about the load test guidelines outside of this lab exercise
There are quite a few additional references to CPU limits in later sections of resource-mgmt.md, which may need updating. I will try to fix those in a future PR but need to review it w/ you first.