perf(ci): scope playwright install to chromium in e2e tests - #2827
Merged
Conversation
Target chromium in npx playwright install --with-deps to avoid downloading and installing unused WebKit/Firefox APT packages, preventing job timeouts.
Contributor
There was a problem hiding this comment.
Pull request overview
Scopes Playwright installation to the Chromium browser used by CI, reducing setup time and dependencies.
Changes:
- Installs only Chromium and its system dependencies.
- Aligns installation with the existing Chromium-only test command.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Scopes
npx playwright install --with-depsin.github/workflows/reusable-tests.ymltochromium.Rationale
--project="chromium").npx playwright install --with-depswithout a browser target downloads browser binaries for WebKit and Firefox and installs 180+ multimedia/desktop APT packages viasudo apt-get, causing jobs to hit the 10-minute timeout before tests even begin.chromiumrestricts downloads and dependency checks strictly to what the test suite runs.Verification
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: