Repository navigation
Fix VM desktop assets; JS 1.1.6 - #97
Merged
Merged
Conversation
jackf-beamcloud
approved these changes
Oct 16, 2026
jackf-beamcloud
left a comment
jackf-beamcloud
left a comment
There was a problem hiding this comment.
Looks good: the desktop page now polls vnc.html until the desktop answers (180s cap, stops on 401/403/404) before loading the iframe, Kasm is pinned to image mode, PCManFM stops double-scaling icons, and the clipboard patch is idempotent with an assert if Kasm's client changes. I regenerated vm-image-assets.ts from the sources and the embedded tar matches byte for byte; CI is green.
Non-blocking: if the gateway briefly returns 404 while a fresh VM's route is still coming up, the page will stop at 'Reopen the desktop' instead of waiting; worth confirming 404 can't happen during normal startup, or dropping 404 from the stop list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync desktop scaling, clipboard and readiness fixes. Keep JPEG/WebP encoding. JS 1.1.6; 22 VM tests and package checks pass.